[PATCH] D89525: [amdgpu] Enhance AMDGPU AA.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:104-105
+    if (const LoadInst *LI = dyn_cast<LoadInst>(ObjA)) {
+      // If a generic pointer is loaded from the constant address space, it
+      // could only be a GLOBAL or CONSTANT one as that address space is soley
+      // prepared on the host side, where only GLOBAL or CONSATNT variables are
----------------
Is it true that we couldn't have a relocation for an LDS value?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:106
+      // could only be a GLOBAL or CONSTANT one as that address space is soley
+      // prepared on the host side, where only GLOBAL or CONSATNT variables are
+      // visible. Note that this even holds for regular functions.
----------------
Typo CONSATNT


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89525/new/

https://reviews.llvm.org/D89525