[PATCH] D89177: [cmake] Add support for multiple distributions

Thu Oct 15 17:10:22 PDT 2020

smeenai added a comment.

In D89177#2332675 <https://reviews.llvm.org/D89177#2332675>, @beanz wrote:

> In D89177#2332627 <https://reviews.llvm.org/D89177#2332627>, @ldionne wrote:
>
>> That isn't what I meant. It's entirely okay for the runtimes to be driven via `AddExternalProject` like the runtimes build does, since that's akin to having a separate CMake invocation for each configuration. That's okay.
>>
>> What I'm saying is that if the next logical step is to also add support for multiple distributions in libc++'s build itself (e.g. adding `LIBCXX_<DISTRIBUTION>_ENABLE_SHARED` & al), then I don't think that's a good idea.
>
> Totally agree. That would be the path compiler-rt’s Darwin build goes, and it is a frequent problem.

Agreed as well, and I have no plans of going down that path. The multi-configuration stuff @phosek and I were discussing is related to the support CMake already has for changing flags based on your build configuration (e.g. the `CMAKE_<LANG>_FLAGS_<CONFIG>` variables), but something like `LIBCXX_<DISTRIBUTION>_ENABLE_SHARED` would be pretty different and is not a direction I plan on going in.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89177/new/

https://reviews.llvm.org/D89177