[PATCH] D89004: [LLD] [COFF] Implement a GNU/ELF like -wrap option

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lld/COFF/Symbols.h:141
+  // doesn't know the final contents of the symbol.
+  uint8_t canInline : 1;
+
----------------
rnk wrote:
> MaskRay wrote:
> > This needs to be `unsigned`, instead of `uint8_t`, to have good packing on MSVC (I think).
> Yep, that should be sufficient to fix the error. I'm glad I put the assert in, or we'd never find out about these regressions. :)
Thanks, reapplying it with that fixed soon - and sorry for the breakage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89004/new/

https://reviews.llvm.org/D89004