[PATCH] D89485: [MachineOutliner] Do not outline debug instructions

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 10:10:58 PDT 2020


chill created this revision.
chill added reviewers: paquette, yroux.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
chill requested review of this revision.

The debug location is removed from any outlined instruction. This causes the
MachineVerifier to crash on outlined `DBG_VALUE` instructions.

      

Then, debug instructions are "invisible" to the outliner, that is, two ranges of
instructions from different functions are considered identical if the only
difference is debug instructions (is that right?). Since a debug instruction
from one function is unlikely to provide sensible debug information about all
functions, sharing an outlined sequence, this patch just removes debug
instructions from the outlined functions.


https://reviews.llvm.org/D89485

Files:
  llvm/lib/CodeGen/MachineOutliner.cpp
  llvm/test/CodeGen/ARM/machine-outliner-remove-debug-instr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89485.298411.patch
Type: text/x-patch
Size: 4451 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201015/5ac5726d/attachment.bin>


More information about the llvm-commits mailing list