[PATCH] D89371: [NPM] Port -loop-versioning-licm to NPM

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 09:25:57 PDT 2020


aeubanks added a comment.

To test the NPM, don't add `-enable-new-pm`, but use the proper NPM flag `-passes`. So e.g. `-passes=default<O1>,loop-versioning-licm,licm` in place of `-enable-new-pm -O1 -loop-versioning-licm -licm`.
The failing tests seem fairly brittle and likely fail because the O1 <https://reviews.llvm.org/owners/package/1/> pipeline is slightly different. Especially the names. Maybe the test should instead contain the output IR of running the existing test under -O1, then as the test itself run that IR through the proper passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89371/new/

https://reviews.llvm.org/D89371



More information about the llvm-commits mailing list