[PATCH] D89420: [lld-macho][easy] Fix segment max protection

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 09:11:55 PDT 2020


int3 added inline comments.


================
Comment at: lld/MachO/OutputSegment.cpp:36
+         "TODO: i386 has different maxProt requirements");
+  return initProt(name);
 }
----------------
compnerd wrote:
> It seems that it would be better to replace `initProt` and `maxProt` with just `prot`?  Or just filling in the differences that require this would be a good idea.
Does it make sense to fill in code that we're not going to be able to test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89420/new/

https://reviews.llvm.org/D89420



More information about the llvm-commits mailing list