[PATCH] D89463: [yaml2obj][ELF] - Simplify the code that performs sections validation.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 06:47:59 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: hiraditya, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar requested review of this revision.

This:

1. Changes the return type of `MappingTraits<T>>::validate` to `std::string`

instead of `StringRef`. It allows to create more complex error messages.

2. Implements one of approaches discussed in the D89039 <https://reviews.llvm.org/D89039> thread, which

allows to generalize sections validation.


https://reviews.llvm.org/D89463

Files:
  lld/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp
  llvm/include/llvm/ObjectYAML/DWARFYAML.h
  llvm/include/llvm/ObjectYAML/ELFYAML.h
  llvm/include/llvm/ObjectYAML/MachOYAML.h
  llvm/include/llvm/ObjectYAML/MinidumpYAML.h
  llvm/include/llvm/Support/YAMLTraits.h
  llvm/lib/ObjectYAML/DWARFYAML.cpp
  llvm/lib/ObjectYAML/ELFYAML.cpp
  llvm/lib/ObjectYAML/MachOYAML.cpp
  llvm/lib/ObjectYAML/MinidumpYAML.cpp
  llvm/test/tools/yaml2obj/ELF/gnu-hash-section.yaml
  llvm/unittests/Support/YAMLIOTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89463.298366.patch
Type: text/x-patch
Size: 22854 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201015/a82fc2a1/attachment.bin>


More information about the llvm-commits mailing list