[PATCH] D44285: Fix computeSymbolSizes SEGFAULT on invalid file

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.
Herald added subscribers: rupprecht, MaskRay.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.

Looks like this test isn't testing what's intended - the input file wasn't committed, by the looks of it, so it's just testing llvm-symbolizer attempting to symbolize an address with no input file. I found this as I'm improving llvm-symbolizer to return non-zero on various error cases (including file not found, in this instance).

@aprantl could you see if the necessary test input file could be added?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44285/new/

https://reviews.llvm.org/D44285