[PATCH] D89386: [AMDGPU] Fix access beyond the end of the basic block in execMayBeModifiedBeforeAnyUse.

[Valery Pykhtin via Phabricator via llvm-commits]

vpykhtin marked an inline comment as done.
vpykhtin added a comment.

In D89386#2330465 <https://reviews.llvm.org/D89386#2330465>, @rampitec wrote:

> Actually do we have a test with a call in between def and use?

Probably not, how a call looks like at this stage?



================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:7136
+    for (const MachineOperand &Op : I->operands()) {
+      if (Op.isRegMask() && Op.clobbersPhysReg(AMDGPU::EXEC))
+        return true;
----------------
rampitec wrote:
> It will miss an exec subreg clobbers. Do we even use regmasks except calls? Then if it is a call it cannot be folded anyway.
I took this code from modifiesRegister, need to check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89386/new/

https://reviews.llvm.org/D89386