[PATCH] D88774: Add disassembly counter after disasembly line

[Jiao Lu via Phabricator via llvm-commits]

jiaolu added a comment.

In D88774#2331300 <https://reviews.llvm.org/D88774#2331300>, @arsenm wrote:

> In D88774#2327009 <https://reviews.llvm.org/D88774#2327009>, @jiaolu wrote:
>
>> In D88774#2325404 <https://reviews.llvm.org/D88774#2325404>, @arsenm wrote:
>>
>>> Please work on removing this feature from the backend instead. It's long past time to stop handling this in the compiler
>>
>> There are several shader debugger tools/situation dependent on this feature.
>> e.g. one line like this "s_andn2_b32   vcc_lo, vcc_lo, 0             ;000974: 8A6A806A"
>> 1). we feed the disassembly count "0x000974" to the shader debugger tool to get this line of code execution ,register input and output.
>> 2).Also there is some other shader dump tool,e.g. umr. or windbg  which output a stream of hardware codes,  we can use the hardware code to find matched part of disassembly lines.
>> 3). we also have one shader replacement tool , to drop and replace part of the elf hardware code, if we have full disassembly line with counter and hardware code, it would be handy where to edit hardware code.
>>
>> Hope it explains.
>
> You can disassemble the text section in the tooling. The compiler does not need to provide this at all

@arsenm , okay, i get it.  you want remove whole disassembly part from AMDGPUAsmPrinter.cpp?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88774/new/

https://reviews.llvm.org/D88774