[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

Wed Oct 14 16:04:54 PDT 2020

akhuang marked an inline comment as done.
akhuang added inline comments.

================
Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147
+// For some reason, const_va is not emitted when the target is MS.
+// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va",
+// NOT-MS-SAME:           line: [[@LINE-3]]
+// NOT-MS-SAME:           extraData: i32 42
----------------
rnk wrote:
> dblaikie wrote:
> > Bug or feature? If it's a bug, probably should at least make this comment a "FIXME"
> Feature. The easiest way to understand it is to hallucinate the C++17 `inline` keyword on MSVC static const integer data members with inline initializers. This metadata is probably emitted in MS mode, but it probably comes later on.
Oh, ok. I don't think the metadata for `const_va` is emitted anywhere in MS mode though. I guess it should be.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89072/new/

https://reviews.llvm.org/D89072