[PATCH] D88684: llvm-reduce: Don't replace intrinsic calls with undef

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Since we should catch these cases later on in `reduceInstructionsDeltaPass()` (please add a test), this should be fine i guess.



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceFunctions.cpp:36-37
+            // reduce. Additionally, intrinsics may have additional operand
+            // constraints, and changing to an arbitrary call may radically
+            // change codegen.
+            return !F.isIntrinsic() && !O.shouldKeep();
----------------
Please drop `and changing to an arbitrary call may radically change codegen.`,
that's interestingness's test's problem.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88684/new/

https://reviews.llvm.org/D88684