[PATCH] D88684: llvm-reduce: Don't replace intrinsic calls with undef

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 13:40:44 PDT 2020


lebedev.ri added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceFunctions.cpp:38
+            // change codegen.
+            return !F.isIntrinsic() && !O.shouldKeep();
+          });
----------------
Much like in ReduceAttributes, i don't think we should rely on the `@llvm.` function name prefix,
but should actually check that they are intrinsics, i.e.
`F.getIntrinsicID() != Intrinsic::not_intrinsic`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88684/new/

https://reviews.llvm.org/D88684



More information about the llvm-commits mailing list