[PATCH] D88731: [AArch64] Combine UADDVs to generate vector add

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 13:30:55 PDT 2020


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Yeah. I was going to say that this would replace 3 instructions with 2, so would generally be useful.

But thinking about it, that wouldn't actually be the case for MVE. The two reductions (VADDVA's) would likely overlap better than back to back loads.

The code here looks good to me. If we find we need to handle more cases in the future we can look at it there, and perhaps put some sort of "undo" in for MVE. But in the meantime this patch LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88731/new/

https://reviews.llvm.org/D88731



More information about the llvm-commits mailing list