[PATCH] D89410: [Attributor] Deduce noalias for local global variables with a single use

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

LGTM, cool :)



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2430
   ChangeStatus updateImpl(Attributor &A) override {
-    // TODO: Implement this.
     return indicatePessimisticFixpoint();
----------------
Keep a TODO for things other than globals (don't know yet what but still ;) )


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2441
+          return ChangeStatus::UNCHANGED;
+      }
     return indicatePessimisticFixpoint();
----------------
Maybe even GlobalValue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89410/new/

https://reviews.llvm.org/D89410