[PATCH] D89404: Preserve param alignment in NVPTXLowerArgs pass.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 10:32:04 PDT 2020


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

> NVPTXLowerArgs takes a load of an argument and converts it to



> make alloca with appropriate alignment.
> store into alloca
> addrspacecast to param address space
> load from alloca in param addrspace

It does not quite match what we do here. 
It's more of a

- create a regular alloca with alignment identical to arg
- RAU Arg->Alloca
- copy Arg from param space (and ASC'ing it from generic AS first) to the alloca (it's still in generic AS)

That said, the change itself appears to be correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89404/new/

https://reviews.llvm.org/D89404



More information about the llvm-commits mailing list