[PATCH] D89386: [AMDGPU] Fix access beyond the end of the basic block in execMayBeModifiedBeforeAnyUse.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:7136
+    for (const MachineOperand &Op : I->operands()) {
+      if (Op.isRegMask() && Op.clobbersPhysReg(AMDGPU::EXEC))
+        return true;
----------------
It will miss an exec subreg clobbers. Do we even use regmasks except calls? Then if it is a call it cannot be folded anyway.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:7148
+          if (TRI->regsOverlap(Reg, AMDGPU::EXEC))
+        return true;
+    }
----------------
The indention suggests this return belongs to the else while it belongs to if. Missing braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89386/new/

https://reviews.llvm.org/D89386