[PATCH] D89400: [SimplifyLibCalls] Keep calling convention when simplifying to libcall

[John Brawn via Phabricator via llvm-commits]

john.brawn created this revision.
john.brawn added reviewers: xbolva00, hubert.reinterpretcast, fhahn.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
john.brawn requested review of this revision.

Currently when simplifying to a library function for which no declaration exists a new declaration is created which defaults to the C calling convention. This can cause problems if the definition is of a different calling convention, so use the calling convention of the library call that's being replaced.

Fixes PR45524.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89400

Files:
  llvm/include/llvm/Transforms/Utils/SimplifyLibCalls.h
  llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
  llvm/test/Transforms/InstCombine/ARM/strcmp.ll
  llvm/test/Transforms/InstCombine/call-callconv.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89400.298162.patch
Type: text/x-patch
Size: 14619 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201014/7c3e5f7e/attachment.bin>