[PATCH] D81682: [PGO] Extend the value profile buckets for mem op sizes.

Wed Oct 14 08:33:14 PDT 2020

yamauchi added a comment.

In D81682#2328239 <https://reviews.llvm.org/D81682#2328239>, @dmajor wrote:

> In D81682#2168134 <https://reviews.llvm.org/D81682#2168134>, @yamauchi wrote:
>
>> In D81682#2168028 <https://reviews.llvm.org/D81682#2168028>, @dmajor wrote:
>>
>>> The re-landing of this patch in 4a539faf74b9b4c25ee3b880e4007564bd5139b0 <https://reviews.llvm.org/rG4a539faf74b9b4c25ee3b880e4007564bd5139b0> causes our PGO build of clang to have thousands of
>>>
>>>   LLVM Profile Warning: Unable to track new values: Running out of static counters.  Consider using option -mllvm -vp-counters-per-site=<n> to allocate more value profile counters at compile time. 
>>>
>>> Is that expected? Should the cmake set a higher value of `-vp-counters-per-site` in self-hosted PGO builds?
>>
>> This has been reverted for now. There was a related issue.
>
> Our build bots still show lots of this warning, is that expected?

It may actually be that -vp-counters-per-site needs adjusting. How do you reproduce?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81682/new/

https://reviews.llvm.org/D81682