[PATCH] D88880: [LoopFlatten] Initial support for different types

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 01:25:14 PDT 2020


fhahn added a comment.

In D88880#2329493 <https://reviews.llvm.org/D88880#2329493>, @SjoerdMeijer wrote:

>> We might be able to salvage this by adding a check that the GEP dominates the loop latch?
>
> Thanks, I am picking this up again, and am going to progress this in 2 ways. I will address the existing bug separately.
>
> Here, in this change that addresses different types, I will investigate widening to a wider type so that the transformation should be safe and avoiding more layers of overflow checks.

I guess this is similar to the widening that IndVarSimplify does? Can we just re-use the stuff from there or have IndVarSimplify just do it for us?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88880/new/

https://reviews.llvm.org/D88880



More information about the llvm-commits mailing list