[PATCH] D89025: [RISCV] Add -mtune support

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng marked 3 inline comments as done.
kito-cheng added a comment.

In D89025#2327749 <https://reviews.llvm.org/D89025#2327749>, @luismarques wrote:

> In D89025#2324334 <https://reviews.llvm.org/D89025#2324334>, @khchen wrote:
>
>> RISCV supports `-mcpu` with default empty arch to align gcc's `-mtune` behavior since clang didn't support `-mtune` before. But now clang has `-mtune`, is it a good idea to remove those options? (ex. `rocket-rv32/rv64`, `sifive-7-rv32/64`)
>
> If possible that would good, since -mcpu is deprecated (for e.g. x86_64) or unsupported in GCC (for e.g. RISC-V). So doing that would further align Clang with GCC. But I wonder if this might be too problematic, in terms of compatibility.

Personally I would like to remove `rocket-rv32/rv64`, `sifive-7-rv32/64`, but I didn't remove `rocket-rv32/rv64`, `sifive-7-rv32/64` in version 2 patch,  since I concern about compatibility too, Clang/LLVM 11 already included that, I would prefer create another patch to remove that and discuss that issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89025/new/

https://reviews.llvm.org/D89025