[PATCH] D89344: Introduce convenience macro ASAN_NO_INSTR_PTR.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

I recommend abandon interface change, add a test for llvm/lib/Transforms/Instrumentation if there is no any yet, and document this trick in https://clang.llvm.org/docs/AddressSanitizer.html



================
Comment at: compiler-rt/include/sanitizer/asan_interface.h:328
+// by ASan. Loads and stores on pointers of this type will not be
+// instrumented.
+//
----------------
I don't think it should be here
we don't put here defines for __attribute__((no_sanitize("address")))

Also this header is interface for runtime, and define controls compiler side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89344/new/

https://reviews.llvm.org/D89344