[PATCH] D89085: [llvm] Update default cutoff threshold for machine function splitter.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 22:07:38 PDT 2020


echristo added a comment.

Sorry, didn't see this last time. Couple of inline comments, mostly nits.

-eric



================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:43
+// FIXME: This cutoff value is cpu dependent and should be moved to
+// TargetTransformInfo once we consider enabling this on other platforms.
 static cl::opt<unsigned>
----------------
Can you comment the value? What it's based off of, what it means, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89085/new/

https://reviews.llvm.org/D89085



More information about the llvm-commits mailing list