[PATCH] D88348: [LLD][COFF] When using LLD-as-a-library, always prevent re-entrance on failures

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

In D88348#2328425 <https://reviews.llvm.org/D88348#2328425>, @rnk wrote:

> The code changes seem fine, but I haven't figured out why we need to sprinkle LLD_IN_TEST=1 for every LLD invocation we expect to error. What goes wrong exactly? I thought the point of your change is that, we *won't* re-run LLD when LLD_IN_TEST=2 after it reports an error.

When `LLD_IN_TEST>0` we only emit stdout/stderr on the **last** iteration. But if we crash, FileCheck requires for stout & stderr to be emitted **before** the crash. That was the point for buffering the streams in the previous version of this patch. Either that, or `LLD_IN_TEST=1` below. If you think of other ideas, I would willing to try!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88348/new/

https://reviews.llvm.org/D88348