[PATCH] D86904: [mlir] Support for defining Types in tblgen

[John Demme via Phabricator via llvm-commits]

jdd marked 8 inline comments as done.
jdd added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/TypeDefGen.cpp:73
+/// parameters.
+template <void (*T)(const TypeParameter &, raw_ostream &), bool PrependComma>
+class TypeParamCommaFormatter : public detail::format_adapter {
----------------
rriddle wrote:
> I would prefer that these just be function_ref and boolean fields of the class instead.
That kinda defeats the syntactic niceness. Will convert this to normal class w/ enum to determine the format. This will make the calling syntax longer but preserve the efficiency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86904/new/

https://reviews.llvm.org/D86904