[PATCH] D87975: [IR] MaxObjSize Attribute

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 12:32:00 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/IR/Value.cpp:723
+    if (!AI->isArrayAllocation()) {
+      MaxObjSizeBytes = DL.getTypeStoreSize(AI->getAllocatedType());
+    }
----------------
Can you use llvm::getObjectSize here, instead of rolling your own version that has bugs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87975/new/

https://reviews.llvm.org/D87975



More information about the llvm-commits mailing list