[PATCH] D88965: [Flang][OpenMP] Rework parser changes for OpenMP atomic construct.

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 12:18:25 PDT 2020


clementval added a comment.

> Now coming to what standard 5.0 says for one of the constraints:
>
>   At most one memory-order-clause may appear on the construct. 
>
> So a test like
>
>   !$omp atomic SEQ_CST SEQ_CST read
>        i  = j
>
> Is currently not flagged as semantic error.
> The possible reason which Valentine explained me was that "there should be at least a Enter function for each clauses with a CheckAllowed inside `check-omp-structure.cpp`".
> And those functions lack in `check-omp-structure.cpp` which was my next patch.

This should be done with the `allowedOnce` list in `OMP.td`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88965/new/

https://reviews.llvm.org/D88965



More information about the llvm-commits mailing list