[PATCH] D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 11:57:36 PDT 2020


davidxl added inline comments.


================
Comment at: llvm/test/CodeGen/X86/block_set.ll:3
+
+define i1 @block_filter() !prof !22{
+; CHECK-LABEL: block_filter
----------------
Without this patch, the 'cold' block will be outlined outside the loop nests, right?  It also makes the outer loop tighter which seems better. With this change, if the outer loop is hot, there will be a hole there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89088/new/

https://reviews.llvm.org/D89088



More information about the llvm-commits mailing list