[PATCH] D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added inline comments.


================
Comment at: lld/ELF/Arch/PPC64.cpp:1318
   case R_PPC64_GOT_TPREL_PCREL34:
+  case R_PPC64_DTPREL34:
   case R_PPC64_TPREL34: {
----------------
sfertile wrote:
> Do we not need to adjust the value being relocated by the dynamic thread pointer bias?
> 
> From the ISA:
> ```
> Each DTV pointer points 0x8000 bytes past the start of each TLS block. (For implementation
> reasons, the actual value stored in the DTV may point to the start of a TLS block. However, values
> returned by accessor functions will be offset by 0x8000 bytes.)
> ```
Yes, you are correct we are off by an offset of `0x8000`.
Thank you for finding this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87504/new/

https://reviews.llvm.org/D87504