[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls.ll:1
+; RUN: opt -vector-library=LIBMVEC  -inject-tli-mappings -force-vector-width=4 -force-vector-interleave=1 -loop-vectorize -S < %s | FileCheck %s
+
----------------
spatel wrote:
> Why does this test file use command-line options to specify the vector factor and the other uses metadata?
> If we can use metadata, then can you vary it to get better coverage (for example <2 x double> or <8 x float>)?
FWIW most LV tests use `-force-vector-width`. If we decide to just go for the 'essential' check lines, it should be easy to add multiple run lines with difference VFs from the command line?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88154/new/

https://reviews.llvm.org/D88154