[PATCH] D89234: [AMDGPU] Avoid offset register in MUBUF for direct stack object accesses

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D89234#2327303 <https://reviews.llvm.org/D89234#2327303>, @cdevadas wrote:

> At global-isel, it has already been taken care of.
> The asserts - the cases where it is expecting a register is specifically for sp relative accesses and won't cause a problem after this patch.

It's not:

  [=](MachineInstrBuilder &MIB) { // soffset
    // If we don't know this private access is a local stack object, it
    // needs to be relative to the entry point's scratch wave offset.
    // TODO: Should split large offsets that don't fit like above.
    // TODO: Don't use scratch wave offset just because the offset
    // didn't fit.
    if (!Info->isEntryFunction() && FI.hasValue())
      MIB.addReg(Info->getStackPtrOffsetReg());
    else
      MIB.addImm(0);
  },


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89234/new/

https://reviews.llvm.org/D89234