[PATCH] D89247: [AMDGPU] Add v_fmac_legacy_f32

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/test/MC/AMDGPU/gfx1030_unsupported.s:1
+// RUN: not llvm-mc -arch=amdgcn -mcpu=gfx1030 -mattr=+WavefrontSize32,-WavefrontSize64 %s 2>&1 | FileCheck --implicit-check-not=error: %s
+// RUN: not llvm-mc -arch=amdgcn -mcpu=gfx1030 -mattr=-WavefrontSize32,+WavefrontSize64 %s 2>&1 | FileCheck --implicit-check-not=error: %s
----------------
foad wrote:
> arsenm wrote:
> > The sutarget features are broken and should be all lowercase
> Do you mean they're broken in some other way, as well as not being lowercase?
Shall be enough just to change the case. Subpar, but on par with the rest of the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89247/new/

https://reviews.llvm.org/D89247