[PATCH] D88715: [llvm-objdump] --source: drop the warning when there is no debug info

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D88715#2325275 <https://reviews.llvm.org/D88715#2325275>, @MaskRay wrote:

> The internal user who reported the problem is fine with the approach (if any object has debug info, suppress the warning). This probably makes real world applications less annoying since (crt1.o for exe) crtbegin.o crtend.o are linked into the binary and they typically don't have debug info. Then this appears to boil down to an existence check of `.debug_line`.

Sounds about right to me. Ideally, I'd still want to know if there was a dodgy piece of debug data somewhere which might be causing problems finding source information, but it's not that big a deal if the symbolizer code isn't plumbed up to give that information independently of simply "no debug data found for this location".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88715/new/

https://reviews.llvm.org/D88715