[PATCH] D89218: [DebugInfo] Support for DW_TAG_generic_subrange

Tue Oct 13 00:05:36 PDT 2020

djtodoro added inline comments.

================
Comment at: llvm/lib/AsmParser/LLParser.h:181

-    bool Error(LocTy L, const Twine &Msg) const {
+    bool error(LocTy L, const Twine &Msg) const {
       return Lex.Error(L, Msg);
----------------
alok wrote:
> djtodoro wrote:
> > This should be a separate (NFC) patch. What is the motivation for this? Does this follow the https://llvm.org/docs/ProgrammersManual.html?
> Actually previous patch made pre-built check unhappy.
> https://s3.amazonaws.com/buildkiteartifacts.com/1adfd68e-67d4-4646-be3f-d34c6750f042/f8ab115f-a384-49e8-a048-0f71ab03c5d0/9a2d3de1-03f8-4aa5-bf73-0649ac80bd99/cb7e0517-ba2c-4279-b879-946045e60937/clang-tidy.txt?response-content-type=text%2Fplain&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQPCP3C7L5KVWOABY%2F20201012%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20201012T125417Z&X-Amz-Expires=600&X-Amz-SignedHeaders=host&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEFIaCXVzLWVhc3QtMSJIMEYCIQDc8ieKOzWDEk%2BL0BPwnVZomYsevkqGvyyQf5YvvuWbTwIhAMe3ThgzKm1RHgbJjTu1YP2XpcN85puGzAEQBjYRbrckKr0DCIv%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEQABoMMDMyMzc5NzA1MzAzIgxAEYpGgHkNuGgl8RYqkQMCl7aH3Nb0QpQNi9tvShyV7AhQ0PbgaAGBTKy4LqSfNQ%2Bg7fGW71rAZhte%2Bfi2IYRf0cD9kdM1OSqaVdoY7BHHdWbhP5Rox6pz2yz6Wra9ffz44bfiEyFT6x%2Fywt7%2FSUuFxwf%2F59wc%2FiGK5Uq8%2B2L9wNAxGhQNNpBkizvzRyte7ZXpss92CGuaL8lwbPI1Om4zFBTy040DPOEiL6%2FmO%2BWDtHynPHDUTRbc%2BiX4rw%2BLiMJ%2F8C3g5xHGEjfGIxeQ4tqwh2JyRtMSeTvx4HaGyIxHBCDSSGr6hly3Lk%2Bg2HNYdd6FurldOLDCLYGCSs%2BKAOD2kKa3IZd%2BOBQyBAsle2%2F2YMYuKE02jeSMHg3Ps0WKLmbOqxtXuC6bid0SFapuu2AqTMDZvYDfON%2BXwb4KqYrr%2FjLWdBi%2Bf72SkCvDdrcwTrgycKa%2B6EHjxGEwAoIHIzVcKNPKaJU8tjW1uBKkVqUEZAhWaf4flfdU7jKgGEK2ahFoiMAb0cJ%2Fnhst9KPj26PdQQBAripVTvc%2B4%2FdUrlWEyDDy05D8BTrqASQWXXSDVn4f6gX%2BrKEUBeZM%2BMU55XdjESpYDAMiFCG3NBjl6T7yrImTJRkSGqtWBuqB5i3lhn7M8vLLINmvIy5BVjPS%2BpQbmFqh2d%2Blx2nkZ4EiAcmE5Sf%2F6xkb58%2B%2FqgY5FyyQeH6jm8bni7AdCOIOexw6JCUrG9zGE87MMSDG0jzmougkSmLm1T4%2F1ubu69YjAAFJrO3RkReEM1DpZ96hyMjnOJ8XtUZdGawrLp5IwtBBfR0rEjgd2ZdsRyo8CoLEkPvyOTlJC7f%2B4%2F%2FCVU%2BJETObP4L6zEXCpDP39Tl8Mqw2jeL6UnWeEw%3D%3D&X-Amz-Signature=dad707a9581c146c88549356acc2b69738ab9efb51d4fe385ec556c3a6084b68
> 
> To correct that, changing a macro was needed which led change to other parse functions (to lower case the first letter of function). Along with that I changed few other functions I came across.
>  Your comment for separate patch if only related to "error" or in general ?
I mean in general, any refactoring/renaming should go as a separate (NFC) patch, since the change with that included, becomes very large (and hard for reviewing).

I cannot see the content from the link, but I think you can ignore the clang-format warnings for now, since it isn't related to this change I guess.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89218/new/

https://reviews.llvm.org/D89218