[PATCH] D88773: Reland "[WebAssembly] Emulate v128.const efficiently""

Dan Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 21:31:17 PDT 2020


dweber added a comment.

In D88773#2326696 <https://reviews.llvm.org/D88773#2326696>, @tlively wrote:

> In D88773#2326695 <https://reviews.llvm.org/D88773#2326695>, @dweber wrote:
>
>> Do you know if it would still be the case if you were using getLimitedValue instead of getZExtValue? I want to say yes, but I'm not entirely sure how these two work.
>
> Yes, `getLimitedValue` bottoms out with this line of code: `return ugt(Limit) ? Limit : getZExtValue();` so they are identical in this situation.

That answers all of my questions... now to figure out where I press the checkbox to approve.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88773/new/

https://reviews.llvm.org/D88773



More information about the llvm-commits mailing list