[PATCH] D85062: [WebAssembly] GC constructor functions in otherwise unused archive objects
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 12 15:04:38 PDT 2020
sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.
lgtm % test nits
================
Comment at: lld/test/wasm/Inputs/ctor-setup-call-def.s:21
+
+ .functype def () -> ()
----------------
I've been putting these external declaration in column 0
================
Comment at: lld/test/wasm/Inputs/ctor-setup.s:4
+
+ .section .text._start,"",@
+ .globl _start
----------------
No need to `.section` for functions since each one implicitly gets its own one anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85062/new/
https://reviews.llvm.org/D85062
More information about the llvm-commits
mailing list