[PATCH] D89264: [LICM] Make promotion faster

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 13:33:34 PDT 2020


lebedev.ri added a comment.

An ignorant word of caution: anything can be made faster by making it do less stuff.

> There's no code-size impact on any of the CTMark programs, so code quality impact of the change should be low.

That doesn't really sound like exhaustive-enough test coverage to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89264/new/

https://reviews.llvm.org/D89264



More information about the llvm-commits mailing list