[PATCH] D89218: [DebugInfo] Support for DW_TAG_generic_subrange

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 11:23:07 PDT 2020


aprantl added inline comments.


================
Comment at: llvm/lib/IR/LLVMContextImpl.h:369
+      ConstantAsMetadata *MD1 = dyn_cast_or_null<ConstantAsMetadata>(Node1);
+      ConstantAsMetadata *MD2 = dyn_cast_or_null<ConstantAsMetadata>(Node2);
+      if (MD1 && MD2) {
----------------
Why is `Node1 == Node2` not enough here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89218/new/

https://reviews.llvm.org/D89218



More information about the llvm-commits mailing list