[PATCH] D88832: [TableGen] Add new getAllDerivedDefinitionsTwo function to RecordKeeper

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 11:02:11 PDT 2020


Paul-C-Anagnostopoulos marked an inline comment as done.
Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/docs/TableGen/BackGuide.rst:565
 
-* ``getDef(``\ *name*\ ``)`` return a ``Record`` reference for the named
   concrete record.
----------------
jrtc27 wrote:
> Paul-C-Anagnostopoulos wrote:
> > jrtc27 wrote:
> > > Not relevant to this diff, please just commit this separately as a trivial grammar fix.
> > I'm correcting errors in this new document as I find them. Is it really necessary to patch each one separately?
> No, but I think "correcting a bunch of errors" should be a separate commit (it can be a single commit though) from "adding this new function and documenting it".
Okay, I will remove these two miscellaneous corrections.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88832/new/

https://reviews.llvm.org/D88832



More information about the llvm-commits mailing list