[PATCH] D88832: [TableGen] Add new getAllDerivedDefinitionsTwo function to RecordKeeper
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 12 10:46:14 PDT 2020
jrtc27 requested changes to this revision.
jrtc27 added inline comments.
This revision now requires changes to proceed.
================
Comment at: llvm/docs/TableGen/BackGuide.rst:55-62
-all the information about that class or record. The ``RecordKeeper`` class
-defines a type that must be used to declare these maps if they are requested
-directly.
-
-.. code-block:: text
-
- using RecordMap = std::map<std::string, std::unique_ptr<Record>,
----------------
What happened here? Why has this gone?
================
Comment at: llvm/docs/TableGen/BackGuide.rst:565
-* ``getDef(``\ *name*\ ``)`` return a ``Record`` reference for the named
concrete record.
----------------
Not relevant to this diff, please just commit this separately as a trivial grammar fix.
================
Comment at: llvm/docs/TableGen/BackGuide.rst:704
file locations. To make error reporting easier, five error reporting
-functions are provided, each with four overloads. [all combinations to come]
----------------
What's this doing here? You're not touching error reporting.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88832/new/
https://reviews.llvm.org/D88832
More information about the llvm-commits
mailing list