[PATCH] D88815: Added .tabletype to asm and multiple table support in obj files

[Paulo Matos via Phabricator via llvm-commits]

pmatos marked 2 inline comments as done.
pmatos added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:73
   WasmLimits Limits;
+  uint32_t Index;
 };
----------------
sbc100 wrote:
> For other module elements that include `Index` it looks like it is the first elem in the struct (see `Event` and `Function` below)
That makes total sense. Changed.


================
Comment at: llvm/lib/ObjectYAML/WasmYAML.cpp:305
   IO.mapRequired("Limits", Table.TableLimits);
+  IO.mapRequired("Index", Table.Index);
 }
----------------
sbc100 wrote:
> Move this so its first?
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88815/new/

https://reviews.llvm.org/D88815