[PATCH] D88774: Add disassembly counter after disasembly line

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 10:02:34 PDT 2020


nhaehnle added a comment.

I don't understand how this would help with shader replacement. Can you please explain how you plan to use this?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.h:149
   size_t DisasmLineMaxLen;
+  size_t DisasmCounter;
 };
----------------
The name is too unspecific. Suggestion: `DisasmNumBytes`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88774/new/

https://reviews.llvm.org/D88774



More information about the llvm-commits mailing list