[PATCH] D89219: [ValueTracking] Use assume's noundef operand bundle

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 08:12:24 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4843
+}
+
 static bool isGuaranteedNotToBeUndefOrPoison(const Value *V,
----------------
I thought we had a helper for this, I think it is `hasAttributeInAssume` in `llvm/include/llvm/Analysis/AssumeBundleQueries.h`. If that is not enough we should extend it for sure. This kind of query is common and easy to get wrong. For example, this doesn't handle multiple `noundef` bundles.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89219/new/

https://reviews.llvm.org/D89219



More information about the llvm-commits mailing list