[PATCH] D88928: [Utils] Skip RemoveRedundantDbgInstrs in MergeBlockIntoPredecessor (PR47746)

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Assuming I understand the history correctly, this patch in itself won't introduce any inaccuracy into debug-info, and has a motivating performance example, so LGTM.

As an aside, Vedant wrote:

> I don't think there's a quick way to check whether a function/basicblock has debug instructions (e.g. you can always inline dbg intrinsics into a function without a !dbg attachment).

(Genuine question:) wouldn't dbg intrinsics be useless without a DISubprogram attached to the Function though, seeing how there wouldn't be a DW_AT_subprogram in the dwarf for variables to be placed in?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88928/new/

https://reviews.llvm.org/D88928