[PATCH] D89100: [GlobalISel] Look through truncs and extends in narrowScalarShift

Konstantin Schwarz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 04:28:15 PDT 2020


kschwarz added a comment.

In D89100#2322546 <https://reviews.llvm.org/D89100#2322546>, @arsenm wrote:

> The code asserting in GISelKnownBits is probably broken. An out of bounds shift is not illegal IR

I've created https://reviews.llvm.org/D89232 to fix the code in GISelKnownBits.cpp

I still think the optimization done in this patch is valuable though (with an updated commit message, of course). What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89100/new/

https://reviews.llvm.org/D89100



More information about the llvm-commits mailing list