[PATCH] D89138: [AArch64] Implement .variant_pcs directive

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes marked 3 inline comments as done.
c-rhodes added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:821
+    OutStreamer->emitLabel(CurrentFnSym);
+    return;
+  }
----------------
sdesmalen wrote:
> Should this branch also call `emitFunctionEntryLabel()` ?
> Should this branch also call emitFunctionEntryLabel() ?

I've removed `OutStreamer->emitLabel(CurrentFnSym);` and deferred it to `emitFunctionEntryLabel` since the latter errors if the label has already been emitted.


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64ELFStreamer.cpp:50
 
+  void emitDirectiveVariantPCS(MCSymbol *Symbol) override {
+    OS << "\t.variant_pcs " << Symbol->getName() << "\n";
----------------
sdesmalen wrote:
> nit: `const MCSymbol *Symbol`
> nit: const MCSymbol *Symbol

`emitDirectiveVariantPCS` is defined by the `AArch64TargetStreamer` interface which the asm/elf streamers are based on and the latter modifies the symbol so it can't be const.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89138/new/

https://reviews.llvm.org/D89138