[PATCH] D89191: [ASAN] Make sure we are only processing lifetime markers with offset 0 to alloca

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1083
+    // beginning of the alloca.
+    AllocaInst *AI = findAllocaForValue(II.getArgOperand(1), true);
     if (!AI) {
----------------
Similar problem is if the size of lifetime is smaller then alloca.
Would you like to handle that case, here or in the another patch? 


================
Comment at: llvm/test/Instrumentation/AddressSanitizer/alloca-offset-lifetime.ll:1
+; Test that ASAN will not instrument lifetime markers on alloca offsets.
+;
----------------
Would you like to try to use llvm/utils/update_test_checks.py


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89191/new/

https://reviews.llvm.org/D89191