[PATCH] D89152: [lld][WebAssembly] Add support for -Bsymbolic
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 12 02:08:49 PDT 2020
jhenderson added a comment.
> sbc100 edited reviewers, ... removed: jhenderson.
(I've got a herald rule to auto-add myself to reviews touching llvm-readobj amongst other tools - no point trying to work around it!)
================
Comment at: llvm/tools/llvm-readobj/WasmDumper.cpp:186-189
+ else if (Seg.Offset.Opcode == wasm::WASM_OPCODE_GLOBAL_GET) {
+ ListScope Group(W, "Offset");
+ W.printNumber("Global", Seg.Offset.Value.Global);
+ } else
----------------
Shouldn't this bit have some dedicated llvm-readobj testing?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89152/new/
https://reviews.llvm.org/D89152
More information about the llvm-commits
mailing list