[PATCH] D64393: [AMDGPU] Fix DPP combiner check for exec modification

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 01:24:37 PDT 2020


foad added a comment.

In D64393#2324102 <https://reviews.llvm.org/D64393#2324102>, @vpykhtin wrote:

> I've found the case when execMayBeModifiedBeforeAnyUse randomly leads to a coredump, which is hard to debug. Most likely it's because an instruction beyond the end of a basic block is accessed. This means that the first loop calculates some instructions twice and I was wrong assuming use_nodbg_instructions doesn't repeat them. In fact there is no code in MachineRegisterInfo::verifyUseList that ensures that uses belonging to one instruction should be sequent in the use list nor the traces of such ordering can be found in MachineRegisterInfo::addRegOperandToUseList. I'm going to fix this code.

:)

I think "Diff 6" of this patch should handle that case correctly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64393/new/

https://reviews.llvm.org/D64393



More information about the llvm-commits mailing list