[PATCH] D89142: llvmbuildectomy

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 10 09:20:52 PDT 2020


mehdi_amini added a comment.

In D89142#2323331 <https://reviews.llvm.org/D89142#2323331>, @thieta wrote:

> In D89142#2322663 <https://reviews.llvm.org/D89142#2322663>, @mehdi_amini wrote:
>
>> Wow pretty neat to see `llvmbuild` being removed!
>>
>> That said we are still depending on it (we generate Bazel build file from this and use this in many projects using MLIR like TensorFlow, XLA, IREE...).
>> We need to move away from it: can you ping me and/or @GMNGeoffrey when you get closer to have this in a landing state?
>
> Could the generation of Bazel files be done by parsing the compile_commands.json maybe? that seems like a more "portable" approach since it's a pretty standard format these days.

It isn't clear to me how: the compile_commands.json seems much lower level and does not contain the information we need which is about libraries dependencies. I don't think the library dependency is expressed in the individual compile commands or easy to recover from this.
Bazel is a more "strict" build system where you can't even include a header from another library if you don't declare the dependency.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89142/new/

https://reviews.llvm.org/D89142



More information about the llvm-commits mailing list